Skip to content

refactor(common): convert scripts within packages/common to relative imports #60623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 3 commits into from
Closed

refactor(common): convert scripts within packages/common to relative imports #60623

AndrewKushnir wants to merge 3 commits into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Mar 29, 2025

This commit updates scripts within packages/common to relative imports as a prep work to the upcoming infra updates.

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Mar 29, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 29, 2025
@AndrewKushnir
refactor(common): convert scripts within packages/common to relativ…
6214200 
…e imports

This commit updates scripts within `packages/common` to relative imports as a prep work to the upcoming infra updates.
@AndrewKushnir AndrewKushnir force-pushed the relative_import_refactor_common branch from e2e0eac to 6214200 Compare March 29, 2025 05:38
@AndrewKushnir AndrewKushnir marked this pull request as ready for review March 29, 2025 05:38
@AndrewKushnir
build(common): updating golden files for the @angular/common package
bbb2afd 
This commit updates golden files that got changed after swtiching to relative paths. There are no actual change to the APIs, the golden file updates capture the change in imports.
@AndrewKushnir
test(bazel): update common package contents test to skip chunks
337510d 
This commit updates the `common` package contents test to skip JS chunks, while still making sure that the main entrypoint files are present.
@angular-robot angular-robot bot added area: build & ci Related the build and CI infrastructure of the project area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 31, 2025
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Mar 31, 2025

Presubmit.

devversion
devversion approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Apr 1, 2025 •
edited
Loading

Caretaker note: the TGP is "green", this PR is ready for merge.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2025
@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 1, 2025
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Apr 1, 2025

@AndrewKushnir Same thing as usual. target: major due to patch conflicts.

thePunderWoman pushed a commit that referenced this pull request Apr 1, 2025
@AndrewKushnir @thePunderWoman
build(common): updating golden files for the @angular/common package (
ad65f44 
#60623)

This commit updates golden files that got changed after swtiching to relative paths. There are no actual change to the APIs, the golden file updates capture the change in imports.

PR Close #60623
thePunderWoman pushed a commit that referenced this pull request Apr 1, 2025
@AndrewKushnir @thePunderWoman
test(bazel): update common package contents test to skip chunks (#6…
eb97303 
…0623)

This commit updates the `common` package contents test to skip JS chunks, while still making sure that the main entrypoint files are present.

PR Close #60623
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Apr 1, 2025

This PR was merged into the repository by commit eb97303.

The changes were merged into the following branches: main

@AndrewKushnir AndrewKushnir mentioned this pull request Apr 1, 2025
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 2, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project area: common Issues related to APIs in the @angular/common package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewKushnir @thePunderWoman @devversion