Skip to content

refactor(common): eliminate redundant iterator-to-array conversion #60884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-agius4 wants to merge 1 commit into from
Closed

refactor(common): eliminate redundant iterator-to-array conversion #60884

alan-agius4 wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 16, 2025 •
edited
Loading

Simplifies code by removing unnecessary Array.from usage.

@pullapprove pullapprove bot requested a review from atscott April 16, 2025 10:07
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 16, 2025
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 16, 2025
@alan-agius4 alan-agius4 force-pushed the refactor-iterator-img branch from 2e9855e to 873e5ab Compare April 16, 2025 10:08
@alan-agius4 alan-agius4 removed the request for review from atscott April 16, 2025 10:09
@alan-agius4
refactor(common): eliminate redundant iterator-to-array conversion
79566b2 
Simplifies code by removing unnecessary `Array.from` usage.
@alan-agius4 alan-agius4 force-pushed the refactor-iterator-img branch from 873e5ab to 79566b2 Compare April 16, 2025 10:11
thePunderWoman
thePunderWoman approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 16, 2025
@kirjs
Copy link
Contributor

kirjs commented Apr 16, 2025

This PR was merged into the repository by commit f2b22b0.

The changes were merged into the following branches: main, 19.2.x

@kirjs kirjs closed this in f2b22b0 Apr 16, 2025
kirjs pushed a commit that referenced this pull request Apr 16, 2025
@alan-agius4 @kirjs
refactor(common): eliminate redundant iterator-to-array conversion (#…
c90eea2 
…60884)

Simplifies code by removing unnecessary `Array.from` usage.

PR Close #60884
@alan-agius4 alan-agius4 deleted the refactor-iterator-img branch April 16, 2025 16:52
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 17, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @kirjs @thePunderWoman