Skip to content

Conversation

@arturovt
Copy link
Contributor

In other parts of the code, calls to the assertInInjectionContext function are guarded with ngDevMode. This change aligns these parts of the code with other implementations that drop such assertions in production.

In other parts of the code, calls to the `assertInInjectionContext` function are guarded with `ngDevMode`. This change aligns these parts of the code with other implementations that drop such assertions in production.
@pullapprove pullapprove bot requested a review from thePunderWoman May 21, 2025 11:03
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 21, 2025
@ngbot ngbot bot added this to the Backlog milestone May 21, 2025
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added area: common Issues related to APIs in the @angular/common package target: rc This PR is targeted for the next release-candidate labels May 21, 2025
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label May 21, 2025
@ngbot
Copy link

ngbot bot commented May 21, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

thePunderWoman pushed a commit that referenced this pull request May 21, 2025
In other parts of the code, calls to the `assertInInjectionContext` function are guarded with `ngDevMode`. This change aligns these parts of the code with other implementations that drop such assertions in production.

PR Close #61560
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 9416483.

The changes were merged into the following branches: main, 20.0.x

@arturovt arturovt deleted the refactor/rxjs-interop-ngDevMode-assert-context branch May 21, 2025 11:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants