Skip to content

feat(core): support regular expressions in templates#63857

Closed
crisbeto wants to merge 6 commits intoangular:mainfrom
crisbeto:template-regex
Closed

feat(core): support regular expressions in templates#63857
crisbeto wants to merge 6 commits intoangular:mainfrom
crisbeto:template-regex

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Sep 17, 2025

Updates the template syntax to support inline regular expressions. Also includes some logic to reuse regular expressions between call sites, unless they're marked as global.

@crisbeto
refactor(compiler): tokenize regular expression literals
e04f67d 
Updates the expression lexer to produce tokens for regular expression literals.
@crisbeto
feat(core): support regular expressions in templates
958ef64 
Updates the template syntax to support inline regular expressions.
@crisbeto
refactor(compiler): add output AST node for regular expressions
b17f7df 
Adds the `RegularExpressionLiteral` node to the output AST.
@crisbeto
refactor(compiler-cli): support regular expression literals in AOT co…
62b81a2 
…mpiler

Handles regular expression literals across the template type checker and the various translators.
@crisbeto
refactor(compiler): integrate regular expression literals into pipeline
784795e 
Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.
@crisbeto
docs: add regular expressions to table of supported literals
cce3ff4 
Updates the docs to mention that regular expressions are supported.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Sep 17, 2025
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime labels Sep 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Sep 17, 2025
@crisbeto crisbeto requested a review from devversion September 17, 2025 08:52
@crisbeto crisbeto marked this pull request as ready for review September 17, 2025 08:52
@pullapprove pullapprove bot removed the request for review from devversion September 17, 2025 08:52
@crisbeto crisbeto requested a review from devversion September 17, 2025 09:13
devversion
devversion approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

packages/compiler/src/expression_parser/lexer.ts
!lastToken.isString() &&
!lastToken.isKeyword() &&
!lastToken.isCharacter(chars.$RPAREN) &&
!lastToken.isCharacter(chars.$RBRACKET)
Copy link
Copy Markdown
Member

@devversion devversion Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what places is a regex starting? would it be less cases to catch where it can actually follow?

Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this logic, because the lexer works on a character-by-character basis. When we see a slash, we don't know if it'll be a regex or something like a / b.

Copy link
Copy Markdown
Member

@devversion devversion Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I guess I was trying to ask if it would be simpler to inverse the checks here. E.g. check for left parenthesis— but I think it would likely be more verbose than this, so LGTM

packages/compiler/src/output/output_ast.ts
}

override isConstant() {
return true;
Copy link
Copy Markdown
Member

@devversion devversion Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this have an affect on the template pipeline? do you recall where this is used?

Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, we use it together with the constant pool to determine if a value can be extracted into a variable and reused. I'd consider regexes to be constant since they're immutable.

Copy link
Copy Markdown
Member

@devversion devversion Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I just wondered if the optimization logic with the g flag could be handled via isConstant here.

Copy link
Copy Markdown
Member Author

@crisbeto crisbeto Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried out removing the explicit optimization and relying on isConstant and the ConstantPool doing the right thing and it didn't work so things might've stopped working properly there at some point...

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2025
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Sep 17, 2025

Caretaker note: we may have to patch cl/808162868 into the sync CL.

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@crisbeto @thePunderWoman
feat(core): support regular expressions in templates (#63857)
328a2bf 
Updates the template syntax to support inline regular expressions.

PR Close #63857
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@crisbeto @thePunderWoman
refactor(compiler): add output AST node for regular expressions (#63857)
a1288f8 
Adds the `RegularExpressionLiteral` node to the output AST.

PR Close #63857
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@crisbeto @thePunderWoman
refactor(compiler-cli): support regular expression literals in AOT co…
f2ef838 
…mpiler (#63857)

Handles regular expression literals across the template type checker and the various translators.

PR Close #63857
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@crisbeto @thePunderWoman
refactor(compiler): integrate regular expression literals into pipeli…
dd77233 
…ne (#63857)

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

PR Close #63857
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Sep 17, 2025

This PR was merged into the repository. The changes were merged into the following branches:

thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@crisbeto @thePunderWoman
docs: add regular expressions to table of supported literals (#63857)
32c98e0 
Updates the docs to mention that regular expressions are supported.

PR Close #63857
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025
@AndrewKushnir
Revert "feat(core): support regular expressions in templates (angular…
e144222 
…#63857)"

This reverts commit 328a2bf.
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Sep 17, 2025
@AndrewKushnir
Revert "refactor(compiler): tokenize regular expression literals (ang…
3e2e1ad 
…ular#63857)"

This reverts commit 8a69c06.
@AndrewKushnir AndrewKushnir mentioned this pull request Sep 17, 2025
Closed
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "docs: add regular expressions to table of supported literals (#…
f0883e5 
…63857)" (#63883)

This reverts commit 32c98e0.

PR Close #63883
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "refactor(compiler): integrate regular expression literals int…
0a81784 
…o pipeline (#63857)" (#63883)

This reverts commit dd77233.

PR Close #63883
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "refactor(compiler-cli): support regular expression literals i…
f53c654 
…n AOT compiler (#63857)" (#63883)

This reverts commit f2ef838.

PR Close #63883
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "refactor(compiler): add output AST node for regular expressio…
c7e0c8b 
…ns (#63857)" (#63883)

This reverts commit a1288f8.

PR Close #63883
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "feat(core): support regular expressions in templates (#63857)" (
ae55578 
#63883)

This reverts commit 328a2bf.

PR Close #63883
thePunderWoman pushed a commit that referenced this pull request Sep 17, 2025
@AndrewKushnir @thePunderWoman
Revert "refactor(compiler): tokenize regular expression literals (#63857
a53ef1d 
)" (#63883)

This reverts commit 8a69c06.

PR Close #63883
@crisbeto crisbeto mentioned this pull request Sep 17, 2025
Closed
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
refactor(compiler): tokenize regular expression literals (angular#63857)
f17721e 
Updates the expression lexer to produce tokens for regular expression literals.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
feat(core): support regular expressions in templates (angular#63857)
1363bd7 
Updates the template syntax to support inline regular expressions.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
refactor(compiler): add output AST node for regular expressions (angu…
b5ffb2f 
…lar#63857)

Adds the `RegularExpressionLiteral` node to the output AST.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
refactor(compiler-cli): support regular expression literals in AOT co…
9ac7d67 
…mpiler (angular#63857)

Handles regular expression literals across the template type checker and the various translators.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
refactor(compiler): integrate regular expression literals into pipeli…
d16848f 
…ne (angular#63857)

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@crisbeto @wildcardalice
docs: add regular expressions to table of supported literals (angular…
0c92f76 
…#63857)

Updates the docs to mention that regular expressions are supported.

PR Close angular#63857
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "docs: add regular expressions to table of supported literals (a…
69f6a55 
…ngular#63857)" (angular#63883)

This reverts commit 32c98e0.

PR Close angular#63883
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "refactor(compiler): integrate regular expression literals int…
dea809e 
…o pipeline (angular#63857)" (angular#63883)

This reverts commit dd77233.

PR Close angular#63883
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "refactor(compiler-cli): support regular expression literals i…
06e2d80 
…n AOT compiler (angular#63857)" (angular#63883)

This reverts commit f2ef838.

PR Close angular#63883
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "refactor(compiler): add output AST node for regular expressio…
7df65c9 
…ns (angular#63857)" (angular#63883)

This reverts commit a1288f8.

PR Close angular#63883
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "feat(core): support regular expressions in templates (angular…
78a3354 
…#63857)" (angular#63883)

This reverts commit 328a2bf.

PR Close angular#63883
wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
@AndrewKushnir @wildcardalice
Revert "refactor(compiler): tokenize regular expression literals (ang…
02fa140 
…ular#63857)" (angular#63883)

This reverts commit 8a69c06.

PR Close angular#63883
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Oct 18, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2025
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
refactor(compiler): tokenize regular expression literals (angular#63857)
c39c7be 
Updates the expression lexer to produce tokens for regular expression literals.

PR Close angular#63857
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
feat(core): support regular expressions in templates (angular#63857)
917b2c6 
Updates the template syntax to support inline regular expressions.

PR Close angular#63857
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
refactor(compiler): add output AST node for regular expressions (angu…
274c881 
…lar#63857)

Adds the `RegularExpressionLiteral` node to the output AST.

PR Close angular#63857
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
refactor(compiler-cli): support regular expression literals in AOT co…
49c7876 
…mpiler (angular#63857)

Handles regular expression literals across the template type checker and the various translators.

PR Close angular#63857
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
refactor(compiler): integrate regular expression literals into pipeli…
31ba6c6 
…ne (angular#63857)

Adds support for regular expression literals in the template pipeline and adds some logic to optimize non-global ones.

PR Close angular#63857
inesane pushed a commit to inesane/angular that referenced this pull request Mar 3, 2026
@crisbeto @inesane
docs: add regular expressions to table of supported literals (angular…
6b9d07f 
…#63857)

Updates the docs to mention that regular expressions are supported.

PR Close angular#63857
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: docs Related to the documentation detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @thePunderWoman @devversion