refactor(core): Add custom formatters for Signals

[JeanMeche]

This commit adds a devmode only formatter for Angular signals

Custom formatters must also be enabled in the browser devtools.

Demo:

TESTED= This change doesn't require a TGP, it doesn't affect existing code

[dgp1130]

Some quick initial thoughts, I recognize enough of my own code to know I'm critiquing myself as much as you. 😅

[devversion]

LGTM for public API (even though this is technically excluded anyway, via https://github.com/angular/angular/blob/main/contributing-docs/public-api-surface.md)

Reviewed-for: public-api

[thePunderWoman]

It feels a bit weird to me to put a devtools related formatter inside the primitives folder. I would expect the primitives folder to contain solely things that are primitives related.

[JeanMeche]

This is directly related to the primitives themselves, here the signals. I would expect both Angular and wiz to actually use that formatter.

[thePunderWoman]

@JeanMeche But would the wiz team be importing this itself from the primitives folder or would they just be installing devtools? I'm just wondering if it's better to organize this with the devtools code rather than inside the signals codebase. Would this ever be used outside of devtools?

[JeanMeche]

This is not related to the Angular devtools, but the browser devtools themselves. A custom formatter influences how references are displayed in the sources, the console, etc.

[thePunderWoman]

@JeanMeche Thank you. That clarifies it for me. 👍🏻

[thePunderWoman]

LGTM

[dgp1130]

The Wiz point is a good callout, I can mention this to some Wiz folks once it lands to make sure we install the formatter automatically in the right place so Wiz gets the same benefit.

[JeanMeche]

Caretaker note: This change doesn't require a TGP, it doesn't affect existing code

[JeanMeche]

Here is the to fix the patch CL/810918799

[JeanMeche]

Presubmit is failing and I'm not sure why.

[mturco]

This is pretty cool! And fwiw I agree that it being in the primitives code makes sense

Reviewed-for: primitives-shared

[dgp1130]

@mturco, once this lands, we should figure out where the right place in Wiz is to install it. I feel like this should "just work" for Wiz developers as well.

[kirjs]

TESTED=This change doesn't require a TGP, it doesn't affect existing code

[kirjs]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 2aca6da
• 20.3.x: 8e80083

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}