fix(core): skip leave animations on view swaps #64828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
added
action: review
thePunderWoman
force-pushed
the
swap-fix
branch
2 times, most recently
from
166a205 to
4db1cfe
Compare
thePunderWoman
force-pushed
the
swap-fix
branch
3 times, most recently
from
b168679 to
86a17d2
Compare
thePunderWoman
force-pushed
the
swap-fix
branch
10 times, most recently
from
3fe6328 to
f14e394
Compare
AndrewKushnir
approved these changes
Nov 4, 2025
We accounted for skipping leave animations during moves, but not swaps. This accounts for the swap cases and updates how we deal with swaps and moves. Now we always queue animations and then essentially dequeue them if we attach them back in the same render pass. fixes: angular#64818 fixes: angular#64730
thePunderWoman
force-pushed
the
swap-fix
branch
from
f14e394 to
14bb466
Compare
thePunderWoman
added
action: merge
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accounted for skipping leave animations during moves, but not swaps. This PR accounts for the basic swap case, but turns out list reconciliation by design does not identify every swap case. So we cannot just rely on the basic swap functions. So rather than relying on a skip flag, like we had been, this adds the ability to dequeue an animation after it's been queued.
Now, if we attach a node after a detach within the same render cycle, we can remove the leave animation from the animation queue before it would fire. This ensures swaps and moves are safely handled without unexpectedly removing the nodes.
fixes: #64818
fixes: #64730