refactor(core): export profile event as enum and move profile_types.t… #65091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
requires: TGP
tsc036
force-pushed
the
move-framework-and-profile-types-to-shared
branch
from
8415272 to
d44acc4
Compare
tsc036
force-pushed
the
move-framework-and-profile-types-to-shared
branch
2 times, most recently
from
a1bb684 to
dcbbca1
Compare
tbondwilkinson
approved these changes
Nov 12, 2025
Contributor
Author
|
Caretaker note: Build changes in cl/831475450 need to be patched when these changes are synced to google3. Can someone add the merge: caretaker note for me. |
dgp1130
approved these changes
Nov 13, 2025
…s and framework to shared devtools folder move framework enum and profile_types to a shared folder so it can be used by wiz
tsc036
force-pushed
the
move-framework-and-profile-types-to-shared
branch
from
dcbbca1 to
d2846fd
Compare
mmalerba
approved these changes
Nov 13, 2025
mmalerba
approved these changes
Nov 13, 2025
Contributor
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
There is one failing target, but it is failing at the base cl too, https://fusion2.corp.google.com/invocations/b5dde45b-44cf-49e1-86a8-32c91a59aef2/targets/%2F%2Flaunch%2Fariane%2Fng2%2Fmetamodel%2Fattribute:tests_chrome-linux/tests |
atscott
approved these changes
Nov 17, 2025
…types.ts and framework to shared devtools folder
thePunderWoman
added
target: patch
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and framework to shared devtools folder
move framework enum and profile_types to a shared folder so it can be used by wiz
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ProfilerEventis exported asconst enumwhich causesCannot access ambient const enums when 'isolatedModules' is enabledwhen trying to build the file I'm importing it into. Alsoprofile_types.tsandFrameworkare not located in the devtools folder.Issue Number: N/A
What is the new behavior?
profile_types.tsand theFrameworkenum have been move to a shared devtools folder, so they can be used in the Wiz devtools implementation. In additionProfilerEventhas been exported just as anenumDoes this PR introduce a breaking change?
Other information