[Documentation] Explain how ::ng-deep works #65718
Open
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify usage of Angular's ::ng-deep pseudo class and its implications for global styles.
Gouvernathor
force-pushed
the
patch-1
branch
from
d0255da to
07cee82
Compare
angular-robot
bot
added
area: docs
JeanMeche
added
cla: no
compiler: template pipeline
and removed
compiler: template pipeline
cla: no
labels
|
Deployed adev-preview for 07cee82 to: https://ng-dev-previews-fw--pr-angular-angular-65718-adev-prev-14gyzu2s.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify usage of Angular's ::ng-deep pseudo class and its implications for global styles.
This is a documentation-only change, that explains how
::ng-deepactually works, explaining in effect what was mentioned in #25160.I will also be proposing a change to the discouragement line - though I expect it will require more discussion since it explicitly engages "the Angular team" - to only discourage CSS rules where
::ng-deepappears at the start of the rule / applies to the whole selector.In my view, it is perfectly useful and legitimate to want a component to have style authority on both its template and the children that it's provided with. It's even less drastic than the other ViewEncapsulation modes.