feat(router): add controls for route cleanup #65991
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
atscott
force-pushed
the
routerInjectorCleanup
branch
from
454e237 to
d522cf7
Compare
atscott
force-pushed
the
routerInjectorCleanup
branch
from
d522cf7 to
14415ed
Compare
SkyZeroZx
reviewed
Dec 10, 2025
This commit introduces a new feature to automatically destroy `EnvironmentInjector`s associated with routes that are no longer active or stored. This helps in managing memory by releasing resources held by unused injectors.
Key changes:
- Added `shouldDestroyInjector` and `retrieveStoredRouteHandles` to `RouteReuseStrategy`.
- Introduced `withExperimentalAutoCleanupInjectors` provider function to opt-in to this feature.
- Implemented a "mark and sweep" algorithm to identify and destroy unused injectors.
- Added a dev mode warning if the strategy implements destruction methods but the feature is not enabled.
- Added integration tests to verify the behavior.
This commit also `destroyDetachedRouteHandle`, a standalone function that allows developers to explicitly destroy the component associated with a `DetachedRouteHandle`.
We chose to implement this as a standalone function rather than adding a `destroy()` method to the `DetachedRouteHandle` type to avoid breaking changes. Currently, `DetachedRouteHandle` is defined as `{}`, and many applications mock it as such. Adding a required method to the interface would break these existing tests and usages.
By using a standalone function, we can safely cast the handle to its internal type and invoke destruction without altering the public contract of the handle itself.
This feature is particularly useful for `RouteReuseStrategy` implementations that need to drop stored handles and ensure the associated components are properly cleaned up to prevent memory leaks.
resolves angular#27290
resolves angular#37095
atscott
force-pushed
the
routerInjectorCleanup
branch
from
14415ed to
09a537c
Compare
|
Deployed adev-preview for 726fc25 to: https://ng-dev-previews-fw--pr-angular-angular-65991-adev-prev-tzo73rw0.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
reviewed
Dec 11, 2025
JeanMeche
reviewed
Dec 11, 2025
JeanMeche
reviewed
Dec 12, 2025
AndrewKushnir
approved these changes
Dec 13, 2025
Comment on lines
+40
to
+41
| * This function should be used when a `RouteReuseStrategy` decides to drop a stored handle | ||
| * and wants to ensure that the component is destroyed. |
Contributor
There was a problem hiding this comment.
I'm wondering if we can enforce that somehow (avoid calling this function in other places in the code).
Contributor
Author
There was a problem hiding this comment.
You can call this function from anywhere at any time. This is not called automatically by the router but ad-hoc if/when the user decides to they don't need the handle anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new feature to automatically destroy
EnvironmentInjectors associated with routes that are no longer active or stored. This helps in managing memory by releasing resources held by unused injectors.Key changes:
shouldDestroyInjectorandretrieveStoredRouteHandlestoRouteReuseStrategy.withExperimentalAutoCleanupInjectorsprovider function to opt-in to this feature.This commit also
destroyDetachedRouteHandle, a standalone function that allows developers to explicitly destroy the component associated with aDetachedRouteHandle.We chose to implement this as a standalone function rather than adding a
destroy()method to theDetachedRouteHandletype to avoid breaking changes. Currently,DetachedRouteHandleis defined as{}, and many applications mock it as such. Adding a required method to the interface would break these existing tests and usages.By using a standalone function, we can safely cast the handle to its internal type and invoke destruction without altering the public contract of the handle itself.
This feature is particularly useful for
RouteReuseStrategyimplementations that need to drop stored handles and ensure the associated components are properly cleaned up to prevent memory leaks.resolves #27290
resolves #37095
resolves #15873