Skip to content

refactor(core): Include decorator name in assertTypeDefined only wh… #66090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SkyZeroZx wants to merge 1 commit into from
Closed

refactor(core): Include decorator name in assertTypeDefined only wh… #66090

SkyZeroZx wants to merge 1 commit into from

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Dec 16, 2025 •
edited
Loading

…en ngDevMode is enabled.

Avoids including decorator names in production
assertTypeDefined calls, improving tree-shaking by preventing debug-only metadata from being included in production builds.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SkyZeroZx
refactor(core): Include decorator name in assertTypeDefined only wh…
479cb83 
…en `ngDevMode` is enabled.

Avoids including decorator names in production
`assertTypeDefined` calls, improving tree-shaking by preventing debug-only metadata from being included in production builds.
@pullapprove pullapprove bot requested a review from thePunderWoman December 16, 2025 00:17
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Dec 16, 2025
@ngbot ngbot bot added this to the Backlog milestone Dec 16, 2025
@JeanMeche
Copy link
Member

JeanMeche commented Dec 16, 2025

I'll close that as not worth it and actually impacting readability for a very marginable gain.
Thanks for the suggestion though.

@JeanMeche JeanMeche closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thePunderWoman thePunderWoman Awaiting requested review from thePunderWoman

Assignees

No one assigned

Labels

area: core Issues related to the framework runtime

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@SkyZeroZx @JeanMeche