Skip to content

refactor(core): introduce tree-shakeable runtime error codes for `NgM… #66179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SkyZeroZx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): introduce tree-shakeable runtime error codes for `NgM… #66179

SkyZeroZx wants to merge 1 commit into from
+34 −8

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Dec 18, 2025 •
edited
Loading

…odulehandling andViewContainerRef` errors

Adds new tree-shakeable runtime error codes to improve error reporting for NgModule resolution issues (duplicate or missing IDs) and invalid ViewContainerRef operations involving destroyed views.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SkyZeroZx
refactor(core): introduce tree-shakeable runtime error codes for `NgM…
9d9d995 
…odule` handling and `ViewContainerRef` errors

Adds new tree-shakeable runtime error codes to improve error reporting for
NgModule resolution issues (duplicate or missing IDs) and invalid ViewContainerRef
operations involving destroyed views.
@pullapprove pullapprove bot requested a review from crisbeto December 18, 2025 17:52
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Dec 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Dec 18, 2025
SkyZeroZx
SkyZeroZx commented Dec 18, 2025
View reviewed changes
packages/core/src/errors.ts
NO_COMPONENT_FACTORY_FOUND = 917,
EXTERNAL_RESOURCE_LOADING_FAILED = 918,
DEF_TYPE_UNDEFINED = -919,
NG_MODULE_ID_NOT_FOUND = 923,
Copy link
Contributor Author

@SkyZeroZx SkyZeroZx Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use code 923 since 922 will already be taken once PR #66015 is merged.

@JeanMeche JeanMeche added the memory leak Issue related to a memory leak label Dec 18, 2025
@pullapprove pullapprove bot requested a review from devversion December 18, 2025 23:40
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed memory leak Issue related to a memory leak labels Dec 18, 2025
JeanMeche
JeanMeche approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@SkyZeroZx @JeanMeche