Skip to content

refactor: fix types extraction for private#67898

Closed
atscott wants to merge 3 commits intoangular:mainfrom
atscott:fixtypesprivate
Closed

refactor: fix types extraction for private#67898
atscott wants to merge 3 commits intoangular:mainfrom
atscott:fixtypesprivate

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Mar 26, 2026

fixes types extraction for private entrypoint of language service

@atscott
refactor: fix types extraction for private
c1fcd6c 
fixes types extraction for private entrypoint of language service
@atscott atscott requested a review from josephperrott March 26, 2026 20:27
@angular-robot angular-robot bot added the area: language-service Issues related to Angular's VS Code language service label Mar 26, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2026
@atscott
refactor(language-service): Update getTcbNodesOfTemplateAtPosition to…
223e485 
… be usable without compiler

updates getTcbNodesOfTemplateAtPosition to be usable without ngCompiler instance
so it can be shared with more compiler types
josephperrott
josephperrott approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott added the target: patch This PR is targeted for the next patch release label Mar 26, 2026
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 26, 2026
@atscott
Copy link
Copy Markdown
Contributor Author

atscott commented Mar 26, 2026

This PR was merged into the repository. The changes were merged into the following branches:

atscott added a commit that referenced this pull request Mar 26, 2026
@atscott
refactor: fix types extraction for private (#67898)
a9ca90f 
fixes types extraction for private entrypoint of language service

PR Close #67898
atscott added a commit that referenced this pull request Mar 26, 2026
@atscott
refactor(language-service): Update getTcbNodesOfTemplateAtPosition to…
b453c0c 
… be usable without compiler (#67898)

updates getTcbNodesOfTemplateAtPosition to be usable without ngCompiler instance
so it can be shared with more compiler types

PR Close #67898
@atscott atscott closed this in fb347af Mar 26, 2026
atscott added a commit that referenced this pull request Mar 26, 2026
@atscott
refactor(language-service): Update getTcbNodesOfTemplateAtPosition to…
7234432 
… be usable without compiler (#67898)

updates getTcbNodesOfTemplateAtPosition to be usable without ngCompiler instance
so it can be shared with more compiler types

PR Close #67898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@atscott @josephperrott