feat(core): de-duplicate host directives#67996
Merged
atscott merged 6 commits intoangular:mainfrom Apr 3, 2026
Merged
Conversation
Updates the TCB metadata to pre-compute and store the `TcbReferenceKey`, instead of computing it on the fly.
Moves the `matchSource` into the base metadata so the binder can use it.
Moves the `ClassPropertyMapping` into the compiler, rather than having to pass around the limited `InputOutputPropertySet` interface that is only implemented by `ClassPropertyMapping`.
Requires the `DirectiveMeta` to have a `ref` so that we can find duplicates easily.
crisbeto
added
action: review
angular-robot
bot
added
detected: feature
This was referenced Apr 2, 2026
crisbeto
force-pushed
the
duplicate-host-dirs
branch
3 times, most recently
from
3373f8a to
d301c26
Compare
…conflicts Implements the logic at the compiler level that will de-duplicate host directives and merge them together. It will also report if a conflict is detected during merging.
With host directives we can end up in a situation where the same directive applies multiple times to the same element, potentially with conflicting configurations. The runtime isn't set up for a directive to apply more than once so historically we were throwing an error when we detect duplicates. This ended up limiting the usefulness of host directives to library authors, because it meant that host directives couldn't be reused as much as authors wanted. To address the issue, these changes introduce logic in the compiler and runtime that will de-duplicate host directives with the following logic: 1. If a directive matches once in the template and more than once as a host directive, the host directive matches will be discarded and only the template match will apply. The mental model is that a host directive match represents `Partial<YourDirective>` while a template match represents the full `YourDirective`. 2. If a directive matches multiple times as a host directive, we merge the input/output mappings from all the instances into a single one. If we detect a case where an input/output is exposed under multiple names during the merging process, both the compiler and the runtime will produce an error. Fixes angular#57846.
crisbeto
force-pushed
the
duplicate-host-dirs
branch
from
d301c26 to
a76b3d1
Compare
crisbeto
requested review from
atscott and
thePunderWoman
and removed request for
thePunderWoman
crisbeto
added
the
action: global presubmit
crisbeto
removed
the
action: global presubmit
Member
Author
thePunderWoman
approved these changes
Apr 2, 2026
Contributor
thePunderWoman
left a comment
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
atscott
added
action: merge
atscott
approved these changes
Apr 3, 2026
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With host directives we can end up in a situation where the same directive applies multiple times to the same element, potentially with conflicting configurations. The runtime isn't set up for a directive to apply more than once so historically we were throwing an error when we detect duplicates.
This ended up limiting the usefulness of host directives to library authors, because it meant that host directives couldn't be reused as much as authors wanted. To address the issue, these changes introduce logic in the compiler and runtime that will de-duplicate host directives with the following logic:
Partial<YourDirective>while a template match represents the fullYourDirective.Fixes #57846.