docs: add FormField/FormRoot imports + move comment with ``'s#68586
Open
michael-small wants to merge 1 commit intoangular:mainfrom
Open
docs: add FormField/FormRoot imports + move comment with ``'s#68586michael-small wants to merge 1 commit intoangular:mainfrom
FormField/FormRoot imports + move comment with ``'s#68586michael-small wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
FormRootwas missing it's TS importIssue Number: N/A
What is the new behavior?
importsand thetemplate, still effectively above the reference to theformField. I think it looks fine and makes sense.FormRoothas its TS import tooFormFieldto the HTML makes the example file work as a valid component file in its entirety. I know the docs sometimes cut certain TS/HTML imports if they were covered and not the main focus, but IMO one line to make the full block compile is nice.Does this PR introduce a breaking change?
Other information
I imagine point 1 and point 3 may be a bit contentious.
Also congrats on the announcement about going stable!