refactor(core): remove deprecated UNSAFE_IFRAME_ATTRS alias#68706
Open
erkamyaman wants to merge 1 commit into
Open
refactor(core): remove deprecated UNSAFE_IFRAME_ATTRS alias#68706erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
`UNSAFE_IFRAME_ATTRS` in the `RuntimeErrorCode` enum is a `@deprecated` alias of `UNSAFE_ATTRIBUTE_BINDING` (same value -910) with no usages anywhere. Drop it along with the paired `tslint:disable-next-line:no-duplicate-enum-values` suppression. `RuntimeErrorCode` is re-exported as `ɵRuntimeErrorCode`, so the enum's value set is not a stability commitment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
packages/core/src/errors.tsdeclaresUNSAFE_IFRAME_ATTRS = -910in theRuntimeErrorCodeenum as a@deprecatedalias ofUNSAFE_ATTRIBUTE_BINDING(same numeric value). It has no usages anywhere in the repo and carries atslint:disable-next-line:no-duplicate-enum-valuessuppression to silence the duplicate-value warning.What is the new behavior?
The alias and its paired tslint suppression are removed.
UNSAFE_ATTRIBUTE_BINDINGstays.Does this PR introduce a breaking change?