fix(common): prevent prototype pollution in formatDateTime#69013
Open
arturovt wants to merge 1 commit into
Open
fix(common): prevent prototype pollution in formatDateTime#69013arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
angular-robot
Bot
added
the
area: common
Member
|
|
Replace `in` operator with `Object.hasOwn` in formatDateTime to prevent prototype pollution attacks. The `in` operator traverses the prototype chain, meaning a polluted Object.prototype key could be picked up as a valid replacement value. This is especially critical in SSR environments where a single prototype pollution attack persists across all subsequent requests in the shared Node.js process, potentially injecting malicious content into every user's rendered HTML. Using `Object.hasOwn` restricts the lookup to own properties only, blocking prototype chain traversal.
arturovt
force-pushed
the
fix/common_formatDateTime_pollution
branch
from
47feb3e to
c889053
Compare
Contributor
Author
Updated |
JeanMeche
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
inoperator withObject.hasOwninformatDateTime to prevent prototype pollution attacks.
The
inoperator traverses the prototype chain, meaning a pollutedObject.prototype key could be picked up as a valid replacement value.
This is especially critical in SSR environments where a single
prototype pollution attack persists across all subsequent requests in
the shared Node.js process, potentially injecting malicious content
into every user's rendered HTML.
Using
Object.hasOwnrestricts the lookup toown properties only, blocking prototype chain traversal.