Skip to content

ci(dart): Uncomment dart.dev build and make it required#6958

Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:dart_dev
Closed

ci(dart): Uncomment dart.dev build and make it required#6958
kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq:dart_dev

Conversation

@kegluneq
Copy link
Copy Markdown

@kegluneq kegluneq commented Feb 8, 2016

Closes #6823, #6410

@kegluneq kegluneq force-pushed the dart_dev branch 2 times, most recently from 2166a98 to 9647b53 Compare February 11, 2016 19:31
@kegluneq kegluneq force-pushed the dart_dev branch 2 times, most recently from 0fc1c85 to 9414a97 Compare February 18, 2016 01:20
@kegluneq kegluneq added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 18, 2016
@alexeagle alexeagle added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 18, 2016
@alexeagle alexeagle removed their assignment Feb 18, 2016
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Feb 18, 2016
@kegluneq
Copy link
Copy Markdown
Author

Dart.dev is now green and is the only task affected, so this should be safe to merge despite saucelabs & js.dev failures.

Thanks!

@kegluneq kegluneq assigned vsavkin and unassigned matsko Feb 25, 2016
Workaround for dart-lang/dartdoc#1099: remove
the `--input=.` parameter to `dartdoc`.

Closes angular#6823, angular#6410
@mary-poppins
Copy link
Copy Markdown

Merging PR #6958 on behalf of @vsavkin to branch presubmit-vsavkin-pr-6958.

@mhevery mhevery closed this in f72f137 Mar 1, 2016
@kegluneq kegluneq deleted the dart_dev branch March 7, 2016 18:20
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dart.dev build times out after 2h

6 participants