(fix) MockCOnnection.mockError also accepts a Response

[nexus-uw]

• updates check if the PR fulfills these requirements**
• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  fix + resolves a TODO in the code base

Does this PR introduce a breaking change?

• No
• What is the current behavior? (You can also link to an open issue here)
  MockConnection.mockError only accepts an Error
• What is the new behavior (if this is a feature change)?
  MockConnection.mockError now also accepts a Response object (so that people can test non-200 level status codes in their responses

[nexus-uw]

note: travis CI build is failing due a change in the public API

[mhevery]

already merged as c5d8e1e777e67ea3ba6ca5fb85e8d63032510dd0

[paulcadman]

We can't find c5d8e1e777e67ea3ba6ca5fb85e8d63032510dd0 in the repository - was this PR merged? We'd like this fix for our tests.

[ckuetbach]

@mhevery
This is still not possible in 2.0.0 final.

MockBackend, Line 101

[amay0048]

+1 for this, it currently means that the mocks don't replicate server interaction correctly

[vicb]

Could someone please re-open a PR if this is still a pb (can not re-open this one as the beanch has been deleted).

Thanks.

[amay0048]

You can actually extend Response and implement Error to get this working:

import { Response, ResponseOptions, ResponseType, Request } from '@angular/http';
import { MockConnection } from '@angular/http/testing';

class MockError extends Response implements Error {
    name:any
    message:any
}

...
handleConnection(connection:MockConnection) {
    let body = JSON.stringify({key:'val'});
    let opts = {type:ResponseType.Error, status:404, body: body};
    let responseOpts = new ResponseOptions(opts);
    connection.mockError(new MockError(responseOpts));
}

[gkohen]

@amay0048, does the above code passes compilation for you considering MockError does not have all the properties required by RequestOptions?

[amay0048]

Yes, it compiles for me. It inherits all the properties of response via the extends.

[emersonf]

@amay0048 thanks for the suggestion, works for me.

From a naming standpoint, I went with ErrorResponse. Code then looks like...

class ErrorResponse extends Response implements Error {
    name: any
    message: any
}
...
        if (...) {
            console.info("login successful");

            c.mockRespond(new Response(new ResponseOptions({
                body: {},
                status: 200
            })));
        }
        else {
            console.info('login failed');

            c.mockError(new ErrorResponse(new ResponseOptions({
                body: {},
                status: 401
            })));
        }

[JohannesRudolph]

Just stumbled across this. The pull request should be indeed reopened.

[DzmitryShylovich]

#13104

[royling]

so no plan to merge this change? #13104 is also closed without merging.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}