Skip to content

Conversation

@chuckjaz
Copy link
Contributor

@chuckjaz chuckjaz commented Jun 8, 2016

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

The collector would report an error for type references of the form a.b if a even if a was an imported module.

What is the new behavior?

The collector now translates qualified access to a module symbol as a special case and translates them into import references.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

Also includes fixes for broken test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an integration test to the compiler_cli that uses different kinds of imports, including import * as ...?

@tbosch
Copy link
Contributor

tbosch commented Jun 8, 2016

Could you also add a note that this also changes the error messages in the commit message?

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 8, 2016
@chuckjaz
Copy link
Contributor Author

chuckjaz commented Jun 8, 2016

There is already a mention that the the commit fixes broken tests. The message text didn't change, a previous commit broke the tests and this PR fixes them.

@chuckjaz chuckjaz force-pushed the import-fix branch 2 times, most recently from 6573861 to c03f42a Compare June 8, 2016 18:14
@chuckjaz chuckjaz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 8, 2016
@chuckjaz chuckjaz force-pushed the import-fix branch 3 times, most recently from a69f396 to 0c56d34 Compare June 9, 2016 16:31
Also includes fixes for broken test.
@chuckjaz chuckjaz merged commit e178ee4 into angular:master Jun 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants