feat(tabs): support stretched tabs in mat-tab-nav-bar#10368
feat(tabs): support stretched tabs in mat-tab-nav-bar#10368andrewseguin merged 1 commit intoangular:masterfrom
Conversation
Adds support for stretched tabs in the tab nav bar. Also removes a duplicate selector. Fixes angular#8871.
googlebot
added
the
cla: yes
| position: relative; | ||
| overflow: hidden; // Keeps the ripple from extending outside the element bounds | ||
|
|
||
| [mat-stretch-tabs] & { |
There was a problem hiding this comment.
Shouldn't this be the same css targeting as for regular tabs?
Regular tabs are:
.mat-tab-group[mat-stretch-tabs] .mat-tab-label
Tab nav is:
.mat-tab-link[mat-stretch-tabs]
Should it be?
mat-tab-links .mat-tab-link[mat-stretch-tabs]
There was a problem hiding this comment.
This selector will end up being transpiled to [mat-stretch-tabs] .mat-tab-link. The only difference is that I didn't prepend the .mat-tab-links, but I wanted to make the selector less specific.
There was a problem hiding this comment.
Sorry, apparently I was not fully awake when I read this selector. I see it now. Awesome.
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Adds support for stretched tabs in the tab nav bar. Also removes a duplicate selector.
Fixes #8871.