Skip to content

build: enable strict attribute type checking #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelbourn merged 1 commit into from
Jan 16, 2020
Merged

build: enable strict attribute type checking #17977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a11y-demo/dialog/dialog-neptune-a11y.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ <h2 mat-dialog-title>Neptune</h2>
Read more on Wikipedia
</a>

<button mat-button color="secondary" (click)="showInStackedDialog()">
<button mat-button color="accent" (click)="showInStackedDialog()">
Show in dialog</button>
</mat-dialog-actions>
2 changes: 1 addition & 1 deletion src/a11y-demo/progress-spinner/progress-spinner-a11y.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<section>
<h2>Loading indicator (Indeterminate progress spinner)</h2>
<mat-spinner color="indeterminate" [strokeWidth]="1" aria-label="Loading"></mat-spinner>
<mat-spinner mode="indeterminate" [strokeWidth]="1" aria-label="Loading"></mat-spinner>
<mat-spinner color="accent" aria-label="Loading"></mat-spinner>
</section>

Expand Down
6 changes: 3 additions & 3 deletions src/universal-app/kitchen-sink-mdc/kitchen-sink-mdc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ <h2>Tabs</h2>

<nav mat-tab-nav-bar>
<a mat-tab-link href="https://google.com">Google</a>
<a mat-tab-link href="https://google.com" active>Also Google</a>
<a mat-tab-link href="https://google.com" [active]="true">Also Google</a>
</nav>

<h2>Progress bar</h2>
<mat-progress-bar value="25"></mat-progress-bar>
<mat-progress-bar mode="buffer" value="25" bufferValue="60"></mat-progress-bar>
<mat-progress-bar [value]="25"></mat-progress-bar>
<mat-progress-bar mode="buffer" [value]="25" [bufferValue]="60"></mat-progress-bar>
<mat-progress-bar mode="indeterminate"></mat-progress-bar>
<mat-progress-bar mode="query"></mat-progress-bar>
4 changes: 2 additions & 2 deletions src/universal-app/kitchen-sink/kitchen-sink.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ <h2>Menu</h2>
<h2>Progress bar</h2>

<mat-progress-bar value="25"></mat-progress-bar>
<mat-progress-bar mode="buffer" value="25" bufferValue="60"></mat-progress-bar>
<mat-progress-bar mode="buffer" value="25" [bufferValue]="60"></mat-progress-bar>
<mat-progress-bar mode="indeterminate"></mat-progress-bar>
<mat-progress-bar mode="query"></mat-progress-bar>

Expand Down Expand Up @@ -225,7 +225,7 @@ <h2>Tabs</h2>

<nav mat-tab-nav-bar>
<a mat-tab-link href="https://google.com">Google</a>
<a mat-tab-link href="https://google.com" active>Also Google</a>
<a mat-tab-link href="https://google.com" [active]="true">Also Google</a>
</nav>

<h2>Paginator</h2>
Expand Down
3 changes: 1 addition & 2 deletions tools/bazel/postinstall-patches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const fs = require('fs');
* Version of the post install patch. Needs to be incremented when patches
* have been added or removed.
*/
const PATCH_VERSION = 1;
const PATCH_VERSION = 2;

/** Path to the project directory. */
const projectDir = path.join(__dirname, '../..');
Expand Down Expand Up @@ -120,7 +120,6 @@ searchAndReplace(`[formatProperty + "_ivy_ngcc"]`, '[formatProperty]',
searchAndReplace(/angular_compiler_options = {/, `$&
"strictTemplates": True,
"strictDomLocalRefTypes ": False,
"strictAttributeTypes": False,
"strictDomEventTypes": False,`, 'node_modules/@angular/bazel/src/ng_module.bzl');

// More info in https://github.com/angular/angular/pull/33786
Expand Down