build: create script that simplifies bazel testing workflow #18016
Conversation
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
Instead of remembering what individual browser targets are called, and what the convention for Bazel labels is, we should just provide a script that simplifies the Bazel testing workflow. e.g. ```bash yarn test button [--local] [--firefox] [--no-watch] yarn test src/material/button src/cdk/bidi yarn test button slider coercion ``` Eventually we should document this script better in one of the contributing markdown files, but these docs need a general cleanup since they still mention Gulp.
devversion
force-pushed
the
build/script-to-run-tests
branch
from
69ad269 to
f30edba
Compare
| * | ||
| * Supported command line flags: | ||
| * | ||
| * --local | If specified, no browser will be launched. |
There was a problem hiding this comment.
Can we make this the default? Then invert the flag to something like --no-headless
There was a problem hiding this comment.
Do you mean that we do not run any browser by default? (asking because the --local flag does this and you commented on that flag).
If you meant that we run Chrome in non-headless mode by default: I don't think we have a way to launch Chrome through Bazel without headless (it seems to depend on the $DISPLAY env variable).
There was a problem hiding this comment.
I want the command to not pop open a browser window but to also run the tests without having to manually open the page (but you can still open the debug page if you need to)
There was a problem hiding this comment.
I don't think this is possible. The @bazel/karma rules decide based on the platform environment whether the browser runs in headless or non-headless mode. For me on Windows, it always runs headless.
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
This is great! Would love to see at least a minor mention in the Contributing docs.
|
@Splaktar Yeah. I have an item on my list to update it to match our latest changes. IIRC it still references Gulp etc. If you want to have a look at the doc, that would be cool too 😄 |
|
@jelbourn The PR that supposedly fixed the |
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
We can see about the upstream behavior as a separate concern
jelbourn
added
pr: lgtm
action: merge
…18016) Instead of remembering what individual browser targets are called, and what the convention for Bazel labels is, we should just provide a script that simplifies the Bazel testing workflow. e.g. ```bash yarn test button [--local] [--firefox] [--no-watch] yarn test src/material/button src/cdk/bidi yarn test button slider coercion ``` Eventually we should document this script better in one of the contributing markdown files, but these docs need a general cleanup since they still mention Gulp.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
Instead of remembering what individual browser targets are called,
and what the convention for Bazel labels is, we should just provide
a script that simplifies the Bazel testing workflow. e.g.
Eventually we should document this script better in one of the
contributing markdown files, but these docs need a general cleanup
since they still mention Gulp.