Skip to content

build: patch rules_sass to properly report errors in worker mode #18248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Jan 22, 2020
Merged

build: patch rules_sass to properly report errors in worker mode #18248

jelbourn merged 1 commit into from
Jan 22, 2020

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 22, 2020

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 22, 2020
@devversion devversion requested a review from jelbourn as a code owner January 22, 2020 10:43
@devversion devversion requested a review from a team January 22, 2020 10:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 22, 2020
josephperrott
josephperrott approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 22, 2020
@jelbourn jelbourn merged commit 13f7c54 into angular:master Jan 22, 2020
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
@devversion @yifange
build: patch rules_sass to properly report errors in worker mode (ang…
3ffb334 
…ular#18248)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 22, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @josephperrott @jelbourn @googlebot