build: fix sass async worker patch causing successful builds to fail #18260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sass async worker patch seems to cause successful builds to fail. This is because the `@bazel/worker` package expects the Promise to resolve with a boolean (`true` = good, `false` failing build).
devversion
added
P2
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
crisbeto
approved these changes
Jan 22, 2020
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
…ngular#18260) The sass async worker patch seems to cause successful builds to fail. This is because the `@bazel/worker` package expects the Promise to resolve with a boolean (`true` = good, `false` failing build).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sass async worker patch seems to cause successful builds to fail.
This is because the
@bazel/workerpackage expects the Promise toresolve with a boolean (
true= good,falsefailing build).