Skip to content

Conversation

@crisbeto
Copy link
Member

Proxies the config flag in the test command so that we're able to switch between Ivy and ViewEngine.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 12, 2020
@crisbeto crisbeto requested a review from a team April 12, 2020 15:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2020
Proxies the `config` flag in the test command so that we're able to switch between Ivy and ViewEngine.
@crisbeto
Copy link
Member Author

I've reworked it to use the --view-engine flag @devversion.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 14, 2020
@andrewseguin andrewseguin merged commit f020403 into angular:master Apr 17, 2020
andrewseguin pushed a commit that referenced this pull request Apr 17, 2020
Proxies the `config` flag in the test command so that we're able to switch between Ivy and ViewEngine.

(cherry picked from commit f020403)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
Proxies the `config` flag in the test command so that we're able to switch between Ivy and ViewEngine.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants