Skip to content

build: fix error from latest MDC canary version #20439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Aug 27, 2020
Merged

build: fix error from latest MDC canary version #20439

jelbourn merged 1 commit into from
Aug 27, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 27, 2020

Fixes a compilation error due to MDC changing an interface.

@crisbeto
build: fix error from latest MDC canary version
87b2771 
Fixes a compilation error due to MDC changing an  interface.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Aug 27, 2020
@crisbeto crisbeto requested a review from devversion as a code owner August 27, 2020 17:42
@crisbeto crisbeto requested a review from a team August 27, 2020 17:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2020
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2020
josephperrott
josephperrott approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit de8fd21 into angular:master Aug 27, 2020
jelbourn pushed a commit that referenced this pull request Aug 27, 2020
@crisbeto @jelbourn
build: fix error from latest MDC canary version (#20439)
0cf2d62 
Fixes a compilation error due to MDC changing an  interface.

(cherry picked from commit de8fd21)
annieyw pushed a commit to annieyw/components that referenced this pull request Aug 31, 2020
@crisbeto @annieyw
build: fix error from latest MDC canary version (angular#20439)
57271af 
Fixes a compilation error due to MDC changing an  interface.
mmalerba pushed a commit that referenced this pull request Sep 2, 2020
@crisbeto @mmalerba
build: fix error from latest MDC canary version (#20439)
7770a11 
Fixes a compilation error due to MDC changing an  interface.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 27, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto @josephperrott @andrewseguin @jelbourn @devversion @googlebot