Skip to content

docs: remove node-sass references #22240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmalerba merged 1 commit into from
Mar 16, 2021
Merged

docs: remove node-sass references #22240

mmalerba merged 1 commit into from
Mar 16, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 15, 2021

Removes a couple of references to node-sass which doesn't support @use.

@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release labels Mar 15, 2021
@crisbeto crisbeto requested a review from jelbourn as a code owner March 15, 2021 19:22
@crisbeto crisbeto requested a review from a team March 15, 2021 19:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2021
@crisbeto
docs: remove node-sass references
ecc1357 
Removes a couple of references to `node-sass` which doesn't support `@use`.
@crisbeto crisbeto force-pushed the node-sass-references branch from d44ce2e to ecc1357 Compare March 15, 2021 19:27
josephperrott
josephperrott approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2021
@mmalerba mmalerba merged commit 55845ba into angular:master Mar 16, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 16, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @josephperrott @mmalerba