Skip to content

docs(material/snack-bar): update docs & examples for MDC-based snackbar #25514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

docs(material/snack-bar): update docs & examples for MDC-based snackbar #25514

merged 2 commits into from
Aug 23, 2022

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 22, 2022

No description provided.

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Aug 22, 2022
@mmalerba mmalerba requested review from crisbeto and jelbourn August 22, 2022 20:29
@mmalerba mmalerba requested a review from andrewseguin as a code owner August 22, 2022 20:30
crisbeto
crisbeto approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the dev app demo going to be handled in a separate PR?

@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 23, 2022

what needs to happen for the dev-app? I think it already has demos for both legacy & MDC versions

@crisbeto
Copy link
Member

crisbeto commented Aug 23, 2022

The files of the legacy one should be prefixed with legacy-, the class names should be changed to Legacy* and the route should be renamed to /legacy-snackbar. Also the MDC one should be changed to remove the MDC prefix.

@mmalerba mmalerba requested a review from devversion as a code owner August 23, 2022 17:28
@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 23, 2022

Ok, dev-app updated

crisbeto
crisbeto approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2022
@mmalerba mmalerba merged commit 49792f4 into angular:main Aug 23, 2022
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 23, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @crisbeto @jelbourn