Skip to content

fix(aria/combobox): several small fixes #32202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2025
Merged

fix(aria/combobox): several small fixes #32202

merged 4 commits into from
Nov 5, 2025

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Oct 29, 2025 •
edited
Loading

  • readonly esc behavior
  • use click instead of pointerup
  • typeahead in readonly mode
  • multi-select readonly combobox
  • multi-select examples

@wagnermaciel wagnermaciel requested a review from a team as a code owner October 29, 2025 15:08
@wagnermaciel wagnermaciel requested review from andrewseguin, crisbeto and ok7sai and removed request for a team October 29, 2025 15:08
@wagnermaciel wagnermaciel added the target: minor This PR is targeted for the next minor release label Oct 29, 2025
@alan-agius4
Copy link
Contributor

alan-agius4 commented Oct 30, 2025

@wagnermaciel, shouldn’t this target rc?

@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 5, 2025
@wagnermaciel wagnermaciel added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker and removed target: minor This PR is targeted for the next minor release labels Nov 5, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto November 5, 2025 23:16
@wagnermaciel wagnermaciel merged commit c345614 into angular:main Nov 5, 2025
20 of 22 checks passed
@wagnermaciel
Copy link
Contributor Author

wagnermaciel commented Nov 5, 2025

This PR was merged into the repository. The changes were merged into the following branches:

wagnermaciel added a commit that referenced this pull request Nov 5, 2025
@wagnermaciel
fix(aria/combobox): several small fixes (#32202)
6c46f95 
* fix(aria/combobox): do not open on click

* fix(aria/combobox): handle unselectable tree items

* fix(aria/combobox): multi selection

* docs(aria/combobox): multi select examples

(cherry picked from commit c345614)
adolgachev pushed a commit to adolgachev/components that referenced this pull request Nov 6, 2025
@wagnermaciel @adolgachev
fix(aria/combobox): several small fixes (angular#32202)
dabbfeb 
* fix(aria/combobox): do not open on click

* fix(aria/combobox): handle unselectable tree items

* fix(aria/combobox): multi selection

* docs(aria/combobox): multi select examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wagnermaciel @alan-agius4 @andrewseguin @ok7sai