refactor(multiple): default softDisabled to true #32240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the default value of the input to across all ARIA components. This allows disabled items to receive focus by default, improving keyboard accessibility. - Grid focus coordinates behavior has also been updated to correctly handle focus when is enabled.
tjshiu
requested review from
ok7sai and
wagnermaciel
and removed request for
a team
ok7sai
approved these changes
Nov 3, 2025
ok7sai
reviewed
Nov 3, 2025
| /** Moves focus to the cell at the given coordinates if it's part of a focusable cell. */ | ||
| focusCoordinates(coords: RowCol): boolean { | ||
| if (this.gridDisabled()) { | ||
| if (this.gridDisabled() && !this.inputs.softDisabled()) { |
Member
There was a problem hiding this comment.
I took a look at list-focus and it does not allow focusing on items when a list is disabled https://github.com/angular/components/blob/main/src/aria/private/behaviors/list-focus/list-focus.ts#L101 and can test with https://ng-comp-devapp.web.app/aria-listbox by setting both disabled and softDisabled to true.
so I think we should align the implementation between those two, either
- If a grid/list is disabled, then no cells/items can be focused when
softDisabledsets to true, or - if a grid/list is disabled, cells/items can still be focused when
softDisabledsets to true
Contributor
Author
There was a problem hiding this comment.
After chatting we discussed that it's probably best to keep them all focusable when softDisabled is set to true. So for consistency I have updated listbox.
…This commit refines the behavior across several a11y components (List, Listbox, Accordion, Tree) to ensure correct interaction between disabled states and navigation/selection. Specifically:\n\n- In , the method now explicitly checks if the list is disabled before allowing selection updates, preventing unintended selections when permits navigation.\n- In , a new method is introduced to clearly distinguish between a 'hard' disabled state (blocking all interaction) and a 'soft' disabled state (allowing navigation but blocking selection).\n- Corresponding tests in , , , and have been updated and expanded to accurately reflect and verify these refined interactions, ensuring that navigation and selection behave as expected in various disabled scenarios.
ok7sai
reviewed
Nov 4, 2025
| return this.inputs.disabled() || this.inputs.items().every(i => i.disabled()); | ||
| } | ||
|
|
||
| /** Whether the list is in a disabled state, but should still be focusable */ |
Member
There was a problem hiding this comment.
Should this be "list is in a disabled state and not focusable" or "list is in a hard disabled state"? The current doc comment sounds suggesting the list can be focused.
tjshiu
added
target: rc
Contributor
Author
tjshiu
added a commit
that referenced
this pull request
Nov 4, 2025
* refactor(multiple): default softDisabled to true Updates the default value of the input to across all ARIA components. This allows disabled items to receive focus by default, improving keyboard accessibility. - Grid focus coordinates behavior has also been updated to correctly handle focus when is enabled. * fix(cdk/a11y): update tests to reflect correct behavior * refactor(cdk/a11y): refine softDisabled behavior and update tests\n\nThis commit refines the behavior across several a11y components (List, Listbox, Accordion, Tree) to ensure correct interaction between disabled states and navigation/selection. Specifically:\n\n- In , the method now explicitly checks if the list is disabled before allowing selection updates, preventing unintended selections when permits navigation.\n- In , a new method is introduced to clearly distinguish between a 'hard' disabled state (blocking all interaction) and a 'soft' disabled state (allowing navigation but blocking selection).\n- Corresponding tests in , , , and have been updated and expanded to accurately reflect and verify these refined interactions, ensuring that navigation and selection behave as expected in various disabled scenarios. (cherry picked from commit 28a50f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default value of the input to across all ARIA components. This allows disabled items to receive focus by default.
softDisabledis true.Why should this be done?
https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/#kbd_disabled_controls
(From W3C) For the following composite widget elements, keep them focusable when disabled:
It's good a11y practice for disabled items to still be focusable