Skip to content

fix(aria/menu): rtl text direction #32254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

fix(aria/menu): rtl text direction #32254

merged 2 commits into from
Nov 4, 2025

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Nov 4, 2025

  • add missing support for rtl text direction
  • add an rtl menu bar example to the dev-app

@wagnermaciel wagnermaciel requested a review from a team as a code owner November 4, 2025 23:05
@wagnermaciel wagnermaciel requested review from crisbeto and tjshiu and removed request for a team November 4, 2025 23:05
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 4, 2025
@wagnermaciel wagnermaciel requested a review from ok7sai November 4, 2025 23:07
@wagnermaciel wagnermaciel added target: rc This PR is targeted for the next release-candidate dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Deployed dev-app for a76c0db to: https://ng-dev-previews-comp--pr-angular-components-32254-dev-r5kxv19g.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

ok7sai
ok7sai approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In examples there are a few submenu carets facing wrong direction in RTL.

@wagnermaciel
Copy link
Contributor Author

wagnermaciel commented Nov 4, 2025

In examples there are a few submenu carets facing wrong direction in RTL.

Are they? I think they're meant to point to the left since that's the direction the submenus open in

@ok7sai
Copy link
Member

ok7sai commented Nov 4, 2025

Oops never mind. I was looking at the non-RTL examples.

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2025
@wagnermaciel wagnermaciel merged commit 969a9ab into angular:main Nov 4, 2025
30 of 32 checks passed
@wagnermaciel
Copy link
Contributor Author

wagnermaciel commented Nov 4, 2025

This PR was merged into the repository. The changes were merged into the following branches:

wagnermaciel added a commit that referenced this pull request Nov 4, 2025
@wagnermaciel
fix(aria/menu): rtl text direction (#32254)
4b5db13 
* fix(aria/menu): rtl text direction

* docs(aria/menu): rtl menu bar example

(cherry picked from commit 969a9ab)
adolgachev pushed a commit to adolgachev/components that referenced this pull request Nov 6, 2025
@wagnermaciel @adolgachev
fix(aria/menu): rtl text direction (angular#32254)
4ca2a10 
* fix(aria/menu): rtl text direction

* docs(aria/menu): rtl menu bar example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagnermaciel @ok7sai