refactor(multiple): Use simple function call for generated ids in angular/aria #32296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
force-pushed
the
aria-signals
branch
from
ec26b8c to
8e02a66
Compare
adolgachev
changed the title
adolgachev
added
the
action: review
adolgachev
force-pushed
the
aria-signals
branch
from
8e02a66 to
3d0d1e1
Compare
adolgachev
changed the title
adolgachev
changed the title
adolgachev
requested review from
andrewseguin,
tjshiu and
wagnermaciel
and removed request for
a team
adolgachev
force-pushed
the
aria-signals
branch
from
f8db67a to
0829b89
Compare
adolgachev
changed the title
Contributor
|
Heads up that we'll just change these to inputs anyways, so users can put their own IDs and we won't clobber them |
Contributor
Author
Oh nice, that works, just didn't want that TODO left in there, but I'll close in favor of #32320 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.