Skip to content

refactor(multiple): Use simple function call for generated ids in angular/aria #32296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

refactor(multiple): Use simple function call for generated ids in angular/aria #32296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0829b89
refactor(multiple): Use simple function call for generated ids in ang…
adolgachev Nov 4, 2025
879129e
Merge branch 'angular:main' into aria-signals
adolgachev Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/aria/listbox/listbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,8 @@ export class Listbox<V> {
/** A unique identifier for the listbox. */
private readonly _generatedId = inject(_IdGenerator).getId('ng-listbox-', true);

// TODO(wagnermaciel): https://github.com/angular/components/pull/30495#discussion_r1972601144.
/** A unique identifier for the listbox. */
protected id = computed(() => this._generatedId);
protected id = () => this._generatedId;

/** A reference to the parent combobox popup, if one exists. */
private readonly _popup = inject<ComboboxPopup<V>>(ComboboxPopup, {
Expand Down Expand Up @@ -224,9 +223,8 @@ export class Option<V> {
/** A unique identifier for the option. */
private readonly _generatedId = inject(_IdGenerator).getId('ng-option-', true);

// TODO(wagnermaciel): https://github.com/angular/components/pull/30495#discussion_r1972601144.
/** A unique identifier for the option. */
protected id = computed(() => this._generatedId);
protected id = () => this._generatedId;

// TODO(wagnermaciel): See if we want to change how we handle this since textContent is not
// reactive. See https://github.com/angular/components/pull/30495#discussion_r1961260216.
Expand Down
3 changes: 1 addition & 2 deletions src/aria/tree/tree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,8 @@ export class Tree<V> {
/** A unique identifier for the tree. */
private readonly _generatedId = inject(_IdGenerator).getId('ng-tree-', true);

// TODO(wagnermaciel): https://github.com/angular/components/pull/30495#discussion_r1972601144.
/** A unique identifier for the tree. */
protected id = computed(() => this._generatedId);
protected id = () => this._generatedId;

/** A reference to the parent combobox popup, if one exists. */
private readonly _popup = inject<ComboboxPopup<V>>(ComboboxPopup, {
Expand Down
Loading