Skip to content

chore(aria): add required 'value' to ngMenuItem jsdocs #32440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(aria): add required 'value' to ngMenuItem jsdocs #32440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/aria/menu/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ import {Directionality} from '@angular/cdk/bidi';
* <button ngMenuTrigger [menu]="myMenu">Open Menu</button>
*
* <div ngMenu #myMenu="ngMenu">
* <div ngMenuItem>Item 1</div>
* <div ngMenuItem>Item 2</div>
* <div ngMenuItem value="Item 1">Item 1</div>
* <div ngMenuItem value="Item 2">Item 2</div>
* </div>
* ```
*
Expand Down Expand Up @@ -127,14 +127,14 @@ export class MenuTrigger<V> {
* <button ngMenuTrigger [menu]="myMenu">Options</button>
*
* <div ngMenu #myMenu="ngMenu">
* <div ngMenuItem>Star</div>
* <div ngMenuItem>Edit</div>
* <div ngMenuItem [submenu]="subMenu">More</div>
* <div ngMenuItem value="Star">Star</div>
* <div ngMenuItem value="Edit">Edit</div>
* <div ngMenuItem value="More" [submenu]="subMenu">More</div>
* </div>
*
* <div ngMenu #subMenu="ngMenu">
* <div ngMenuItem>Sub Item 1</div>
* <div ngMenuItem>Sub Item 2</div>
* <div ngMenuItem value="Sub Item 1">Sub Item 1</div>
* <div ngMenuItem value="Sub Item 2">Sub Item 2</div>
* </div>
* ```
*
Expand Down Expand Up @@ -287,13 +287,13 @@ export class Menu<V> {
* </div>
*
* <div ngMenu #fileMenu="ngMenu">
* <div ngMenuItem>New</div>
* <div ngMenuItem>Open</div>
* <div ngMenuItem value="New">New</div>
* <div ngMenuItem value="Open">Open</div>
* </div>
*
* <div ngMenu #editMenu="ngMenu">
* <div ngMenuItem>Cut</div>
* <div ngMenuItem>Copy</div>
* <div ngMenuItem value="Cut">Cut</div>
* <div ngMenuItem value="Copy">Copy</div>
* </div>
* ```
*
Expand Down Expand Up @@ -392,9 +392,9 @@ export class MenuBar<V> {
* or action a user can take. They can also act as triggers for sub-menus.
*
* ```html
* <div ngMenuItem (onSelect)="doAction()">Action Item</div>
* <div ngMenuItem value="Action Item" (onSelect)="doAction()">Action Item</div>
*
* <div ngMenuItem [submenu]="anotherMenu">Submenu Trigger</div>
* <div ngMenuItem value="Submenu Trigger" [submenu]="anotherMenu">Submenu Trigger</div>
* ```
*
* @developerPreview 21.0
Expand Down Expand Up @@ -490,8 +490,8 @@ export class MenuItem<V> {
* ```html
* <div ngMenu #myMenu="ngMenu">
* <ng-template ngMenuContent>
* <div ngMenuItem>Lazy Item 1</div>
* <div ngMenuItem>Lazy Item 2</div>
* <div ngMenuItem value="Lazy Item 1">Lazy Item 1</div>
* <div ngMenuItem value="Lazy Item 2">Lazy Item 2</div>
* </ng-template>
* </div>
* ```
Expand Down