fix(material/datepicker): do not re-assign the same forms value #32447
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
32442/signal-forms-datepicker
branch
2 times, most recently
from
03f3fb7 to
895c2e4
Compare
crisbeto
changed the title
The datepicker ControlValueAccessor produces a new date object for each keystroke as the user is typing. When used with the interop behavior from signal forms, this can end up reverting the user's value as they're typing. These changes ignore `writeValue` calls if they pass the exact same date object. Fixes angular#32442.
crisbeto
force-pushed
the
32442/signal-forms-datepicker
branch
from
895c2e4 to
d91bead
Compare
crisbeto
changed the title
wagnermaciel
approved these changes
Dec 2, 2025
Member
Author
crisbeto
added a commit
that referenced
this pull request
Dec 2, 2025
The datepicker ControlValueAccessor produces a new date object for each keystroke as the user is typing. When used with the interop behavior from signal forms, this can end up reverting the user's value as they're typing. These changes ignore `writeValue` calls if they pass the exact same date object. Fixes #32442. (cherry picked from commit 4cc5880)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datepicker ControlValueAccessor produces a new date object for each keystroke as the user is typing. When used with the interop behavior from signal forms, this can end up reverting the user's value as they're typing.
These changes ignore
writeValuecalls if they pass the exact same date object.Fixes #32442.