fix(material/slide-toggle): Fix a11y issues by hiding label when it has no content. #32480
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
force-pushed
the
slide-toggle
branch
from
f85c951 to
a6880e3
Compare
adolgachev
changed the title
adolgachev
force-pushed
the
slide-toggle
branch
from
a6880e3 to
8df50fa
Compare
adolgachev
added
Accessibility
adolgachev
force-pushed
the
slide-toggle
branch
from
24cad4f to
d684ef6
Compare
adolgachev
added
the
action: global presubmit
crisbeto
reviewed
Dec 8, 2025
adolgachev
added
dev-app preview
|
Deployed dev-app for e93609f to: https://ng-dev-previews-comp--pr-angular-components-32480-dev-8wd8hfe4.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for 97fc2d0 to: https://ng-dev-previews-comp--pr-angular-components-32480-docs-jpaocuag.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
slide-toggle
branch
from
0b34f44 to
6b8cbb4
Compare
tjshiu
reviewed
Dec 9, 2025
tjshiu
approved these changes
Dec 9, 2025
crisbeto
approved these changes
Dec 10, 2025
adolgachev
force-pushed
the
slide-toggle
branch
from
5eae231 to
e93609f
Compare
adolgachev
force-pushed
the
slide-toggle
branch
from
e93609f to
97fc2d0
Compare
adolgachev
changed the title
adolgachev
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a11y issues when no label is used, but the label wrapper (with an onclick) is still present. This can lead to an extra interactive tab-stop depending on the screen reader used.
The label element is now set to
display: noneif it is empty.