refactor(material/select): remove dependency on NgClass#32776
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
refactor(material/select): remove dependency on NgClass#32776crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Drops the dependency on `NgClass` from the select component since we can achieve the same with class bindings.
crisbeto
force-pushed
the
select-ng-class
branch
from
06037cb to
0feafcc
Compare
mmalerba
requested review from
andrewseguin
and removed request for
mmalerba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the dependency on
NgClassfrom the select component since we can achieve the same with class bindings.