perf(aria): drop debugName from signals#32904
Open
JoostK wants to merge 1 commit intoangular:mainfrom
Open
Conversation
The `debugName` would always be assigned into a reactive node, incurring the overhead of an additional property in each signal-like instance _and_ introducing additional hidden classes for the JS VM to deal with.
JoostK
commented
Mar 8, 2026
| export function computed<T>(computation: () => T): SignalLike<T> { | ||
| const computed = createComputed(computation); | ||
| // TODO: Remove the `toString` after https://github.com/angular/angular/pull/65948 is merged. | ||
| computed.toString = () => `[Computed: ${computed()}]`; |
Member
Author
There was a problem hiding this comment.
I removed the toString because the linked issue has been merged, but I realized this isn't identical; computed() picks up a reactive dependency whereas the primitives' toString() implementation would not.
Depending on how angular/angular#67511 gets resolved this may need to change here as well, as I think it's beneficial to keep this behavior identical to Angular's primary signal behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
debugNamewould always be assigned into a reactive node, incurring the overhead of an additional property in each signal-like instance and introducing additional hidden classes for the JS VM to deal with.I noticed this in heap snapshots:
which is now:
Since the name was assigned the empty string, I decided to remove it altogether.