fix(material/chips): hide input placeholder when chip grid is disabled#32979
Closed
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Closed
fix(material/chips): hide input placeholder when chip grid is disabled#32979yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
yogeshwaran-c wants to merge 1 commit intoangular:mainfrom
Conversation
The chip input was showing its placeholder text even when the chip grid was disabled, which is confusing because it implies the control is still interactive. In v19 the placeholder was hidden when disabled, so this is a regression. The fix suppresses the placeholder attribute binding when the input is disabled (either directly or through the parent chip grid). Fixes angular#32849
Member
|
It's currently working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mat-chip-gridis disabled, the associatedmatChipInputnow removes its placeholder attribute, preventing misleading placeholder text on a non-interactive inputChanges
chip-input.tshost binding:[attr.placeholder]now checks thedisabledstate before rendering the placeholderTest plan
pnpm test chipsto confirm existing tests pass🤖 Generated with Claude Code