fix(material/select): open handler invoked twice#33119
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(material/select): open handler invoked twice#33119crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
ok7sai
approved these changes
Apr 22, 2026
Member
|
I was looking at the issue and couldn't reproduce the issue with v21 https://stackblitz.com/edit/stackblitz-starters-u3gf9hh9?file=src%2Fmain.ts |
Member
Author
|
I could repro it with the code from #33116, but it actually only happens when you click on the trigger itself, not the |
Fixes that the select's `open` handler was being called twice: once from the trigger's `click` handler and once from the `onContainerClick` callback when the event propagates. Fixes angular#33116.
crisbeto
force-pushed
the
33116/select-double-clicks
branch
from
18b2239 to
bcf58e5
Compare
Member
Author
|
I tried a few different approaches here, but they were all really breaking internally. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the select's
openhandler was being called twice: once from the trigger'sclickhandler and once from theonContainerClickcallback when the event propagates.Fixes #33116.