refactor(multiple): implement generic child discovery with SortedCollection#33151
Open
ok7sai wants to merge 1 commit intoangular:mainfrom
Open
refactor(multiple): implement generic child discovery with SortedCollection#33151ok7sai wants to merge 1 commit intoangular:mainfrom
ok7sai wants to merge 1 commit intoangular:mainfrom
Conversation
ok7sai
force-pushed
the
refactor/sorted-collection
branch
6 times, most recently
from
8f522e8 to
fbd2456
Compare
ok7sai
force-pushed
the
refactor/sorted-collection
branch
from
fbd2456 to
177661f
Compare
crisbeto
approved these changes
Apr 28, 2026
| providers: [{provide: ACCORDION_GROUP, useExisting: AccordionGroup}], | ||
| providers: [ | ||
| {provide: ACCORDION_GROUP, useExisting: AccordionGroup}, | ||
| {provide: ACCORDION_COLLECTION, useFactory: () => inject(AccordionGroup)._collection}, |
Member
There was a problem hiding this comment.
Couldn't whoever is injecting the ACCORDION_GROUP read the _collection off it directly?
Member
Author
There was a problem hiding this comment.
Oops yea you are right. It has gone too far. I was thinking of supporting multiple collections like
{provide: COLLECTION_A, useFactory: () => inject(AccordionGroup)._collectionA},
{provide: COLLECTION_B, useFactory: () => inject(AccordionGroup)._collectionB},
but the fact it can just read ._collectionA and ._collectionB.
Let me clean those up.
| providers: [{provide: LISTBOX, useExisting: Listbox}], | ||
| providers: [ | ||
| {provide: LISTBOX, useExisting: Listbox}, | ||
| {provide: LISTBOX_COLLECTION, useFactory: () => inject(Listbox)._collection}, |
Member
There was a problem hiding this comment.
Same note here about reading the collection off the listbox.
| }); | ||
| } | ||
|
|
||
| ngOnInit() {} |
| providers: [{provide: TABS, useExisting: Tabs}], | ||
| providers: [ | ||
| {provide: TABS, useExisting: Tabs}, | ||
| {provide: TABS_PANEL_COLLECTION, useFactory: () => inject(Tabs)._collection}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated Accordion, Listbox, and Tabs this time.