Autocomplete - Uses simple-combobox example#33155
Open
tjshiu wants to merge 4 commits intoangular:mainfrom
Open
Autocomplete - Uses simple-combobox example#33155tjshiu wants to merge 4 commits intoangular:mainfrom
tjshiu wants to merge 4 commits intoangular:mainfrom
Conversation
Contributor
tjshiu
commented
Apr 27, 2026
tjshiu
commented
- Updated to simple-combobox: Hooked up the autocomplete examples to use the new simple-combobox patterns and wired in the
- Added a softDisabled state to default to true
- Fixed focus management: Swapped out the custom [tabbable] input for standard [tabIndex]="-1"
tjshiu
added
dev-app preview
|
Deployed dev-app for 57da449 to: https://ng-dev-previews-comp--pr-angular-components-33155-dev-ywds9976.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Member
|
I'd suggest adding autocomplete examples with simple combobox to it's own page instead of replacing the current autocomplete, so when we do bug bash we can compare the two examples. |
ok7sai
approved these changes
Apr 28, 2026
…box and add softDisabled
…-combobox variants
tjshiu
force-pushed
the
autocomplete-top
branch
from
358dc7f to
b23841c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.