Skip to content

refactor(aria/combobox): allow adding tabIndex and default it to 0#33183

Merged
tjshiu merged 3 commits intoangular:mainfrom
tjshiu:select
May 1, 2026
Merged

refactor(aria/combobox): allow adding tabIndex and default it to 0#33183
tjshiu merged 3 commits intoangular:mainfrom
tjshiu:select

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented Apr 30, 2026

No description provided.

@pullapprove pullapprove Bot requested review from crisbeto and wagnermaciel April 30, 2026 23:17
@tjshiu tjshiu requested review from adolgachev and ok7sai April 30, 2026 23:17
@tjshiu tjshiu added dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

Deployed dev-app for eafe5fb to: https://ng-dev-previews-comp--pr-angular-components-33183-dev-unhjukr7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Adds the 'tabindex' alias to the 'tabIndex' input signal in Grid, Listbox,
Combobox, and Tree components. This allows the input to be bound using the
more idiomatic lowercase 'tabindex' attribute in templates. Related tests
and examples have also been updated to use the new alias.
Comment thread src/aria/simple-combobox/simple-combobox.ts Outdated
@tjshiu tjshiu added the action: merge The PR is ready for merge by the caretaker label May 1, 2026
@tjshiu tjshiu merged commit 60234c2 into angular:main May 1, 2026
25 of 27 checks passed
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 1, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@tjshiu tjshiu deleted the select branch May 1, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: aria/combobox dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants