Skip to content

docs(material/chips): clean up forms examples#33185

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:33179/chips-docs
May 1, 2026
Merged

docs(material/chips): clean up forms examples#33185
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:33179/chips-docs

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented May 1, 2026

Cleans up the examples showing how to use chips with the forms module so that they have a single source of truth and better match our coding standards.

Fixes #33179.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label May 1, 2026
@pullapprove pullapprove Bot requested review from adolgachev and wagnermaciel May 1, 2026 09:26
@angular-robot angular-robot Bot added area: docs Related to the documentation area: material/chips labels May 1, 2026
Comment thread src/material/tooltip/tooltip.spec.ts Outdated

it('should have a delay when showing on touchstart', async () => {
const fixture = TestBed.createComponent(BasicTooltipDemo);
fixture.componentInstance.showButton = true;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the chips, I'm just trying to stabilize the flaky tests.

@crisbeto crisbeto requested a review from ok7sai May 1, 2026 09:27
@crisbeto crisbeto force-pushed the 33179/chips-docs branch 4 times, most recently from 7c54ece to 960e541 Compare May 1, 2026 11:20
Cleans up the examples showing how to use chips with the forms module so that they have a single source of truth and better match our coding standards.

Fixes angular#33179.
@crisbeto crisbeto force-pushed the 33179/chips-docs branch from 960e541 to 811bd2b Compare May 1, 2026 11:26
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 1, 2026
@crisbeto crisbeto merged commit 7798bb7 into angular:main May 1, 2026
26 checks passed
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented May 1, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(chips): reactive forms example has unsynced signal and FormControl (confusing source of truth)

2 participants