Skip to content

build: attempt to address flaky test#33332

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:aria-listbox-flake
Jun 2, 2026
Merged

build: attempt to address flaky test#33332
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:aria-listbox-flake

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Jun 2, 2026

Tries to resolve a test in the Aria listbox that is flaking on Safari after we switched to using whenStable.

Tries to resolve a test in the Aria listbox that is flaking on Safari after we switched to using `whenStable`.
@crisbeto crisbeto requested a review from ok7sai June 2, 2026 07:02
@crisbeto crisbeto added the target: rc This PR is targeted for the next release-candidate label Jun 2, 2026
@pullapprove pullapprove Bot requested a review from andrewseguin June 2, 2026 07:02
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Jun 2, 2026
Copy link
Copy Markdown
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... my bad.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 2, 2026
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Jun 2, 2026

Let's see if it actually fixes it, this is a bit of a shot in the dark since I couldn't repro it locally 😅

@crisbeto crisbeto merged commit 129be73 into angular:main Jun 2, 2026
33 of 35 checks passed
@crisbeto
Copy link
Copy Markdown
Member Author

crisbeto commented Jun 2, 2026

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jun 2, 2026
Tries to resolve a test in the Aria listbox that is flaking on Safari after we switched to using `whenStable`.

(cherry picked from commit 129be73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants