refactor(icon): use HttpClient instead of Http#6454
Closed
cyrilletuzi wants to merge 1 commit intoangular:masterfrom
cyrilletuzi:cyrilletuzi-http-patch
Closed
refactor(icon): use HttpClient instead of Http#6454cyrilletuzi wants to merge 1 commit intoangular:masterfrom cyrilletuzi:cyrilletuzi-http-patch
cyrilletuzi wants to merge 1 commit intoangular:masterfrom
cyrilletuzi:cyrilletuzi-http-patch
Conversation
cyrilletuzi
requested review from
amcdnl,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
Contributor
Author
|
As it's an important PR and as I'm not an expert in running all the tools and tests, I need special review for :
|
Contributor
|
We haven't made this change yet because it would require bumping to 4.3, which breaks some of our tests (still trying to figure out why) |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 15, 2017
* Bumps the Angular requirement to 4.3. This is also a prerequisite to the Angular 5 update since we encountered the same errors there. * Refactors the sidenav not to use a `Promise.resolve` for toggling the initial animation, because it was making it impossible to flush the animations in unit tests. The new simplified approach uses a property to pass the animation state. * Fixes the nested menu test failures. * Fixes a "changed after checked" error in the autocomplete demo app. Relates to angular#6454.
Member
|
#6483 will add the Angular 4.3 support and sort out the various test failures. |
andrewseguin
pushed a commit
that referenced
this pull request
Aug 16, 2017
* feat: update to Angular 4.3 * Bumps the Angular requirement to 4.3. This is also a prerequisite to the Angular 5 update since we encountered the same errors there. * Refactors the sidenav not to use a `Promise.resolve` for toggling the initial animation, because it was making it impossible to flush the animations in unit tests. The new simplified approach uses a property to pass the animation state. * Fixes the nested menu test failures. * Fixes a "changed after checked" error in the autocomplete demo app. Relates to #6454. * fix: e2e failures
Contributor
Author
|
Closing, as PR #6702 redone the same work... |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5814
Replace old HttpModule with new Angular 4.3+ HttpClientModule.
It allows to delete the dependency to
@angular/http, then smaller app bundles for users.As a consequence, dependencies has been updated to Angular >= 4.3.0.