Skip to content

Conversation

@donroyco
Copy link
Contributor

This fixes #9370

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 13, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 13, 2018
@julianobrasil
Copy link
Contributor

Shouldn't it be better to change the function name to setAriaDescribedByIds?

@donroyco
Copy link
Contributor Author

@julianobrasil Could've gone both ways.

@julianobrasil
Copy link
Contributor

Thinking of it for a second, I can't remember right now where, but I have already seen functions in material library that deals with accessibility and don't mention it in their names.

@donroyco
Copy link
Contributor Author

@julianobrasil Thanks for getting back on this.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit ae4e465 into angular:master Jan 18, 2018
@donroyco donroyco deleted the bugfix/docs-typo-custom-form-field-control branch January 18, 2018 20:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in guide: "Creating a custom form field control"

6 participants