Skip to content

Conversation

@josephperrott
Copy link
Member

See individual commits.

@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 12, 2021
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 13, 2021
@josephperrott josephperrott force-pushed the breaking-changes-label branch from 55e769d to 169468f Compare August 13, 2021 16:34
@josephperrott josephperrott marked this pull request as ready for review August 13, 2021 16:40
…nd remove breaking changes label

Automatically apply and remove breaking changes label based on the presence of a commit containing
a breaking change.

Closes angular#127
@josephperrott josephperrott force-pushed the breaking-changes-label branch from 169468f to b436cf4 Compare August 13, 2021 16:44
josephperrott added a commit that referenced this pull request Aug 13, 2021
…nd remove breaking changes label (#138)

Automatically apply and remove breaking changes label based on the presence of a commit containing
a breaking change.

Closes #127

PR Close #138
import {parseCommitMessage} from '../../ng-dev/commit-message/parse';
import {getAuthTokenForAngularRobotApp} from '../utils';

const breakingChangesLabel = 'breaking changes';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it appears that the label in FW has been changed to flag: breaking change.

angular/angular@ebc80b3#diff-0f6460592cf1db69dc570c128942fb78af50c792b862af847654785406727242

@josephperrott josephperrott deleted the breaking-changes-label branch August 16, 2021 16:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants