build: allow for @devinfra// to be used in downstream repos
#2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when trying to import `@devinfra//` in a workspace that doesn't use `rules_nodejs` anymore, we will surface errors. This is because the top-level BUILD target/package is loaded for the shared tsconfig defaults, while this Bzl package imports from `defaults.bzl` which inherently triggers various load statements for `rules_nodejs`. This shouldn't be the case, and this commit fixes this.
devversion
commented
Feb 25, 2025
angular-robot
bot
added
the
area: build & ci
Member
|
This PR was merged into the repository by commit 07dba2a. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when trying to import
@devinfra//in a workspace that doesn't userules_nodejsanymore, we will surface errors.This is because the top-level BUILD target/package is loaded for the shared tsconfig defaults, while this Bzl package imports from
defaults.bzlwhich inherently triggers various load statements forrules_nodejs.This shouldn't be the case, and this commit fixes this.