refactor: improve setup-wsl action to support native Windows testing #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building inside WSL on the host disk, we should build inside the WSL file system as that is significantly faster and avoids the interop bottleneck. For this, we naively copy over the repository after checkout into WSL; and operate from in there. Pending TODO is how we can properly cache contents inside WSL; as the cache action currently does not seem to pick it up properly.
devversion
force-pushed
the
improve-wsl-2
branch
from
e0ced44 to
0eeab68
Compare
crisbeto
approved these changes
Mar 3, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building inside WSL on the host disk, we should build inside the WSL file system as that is significantly faster and avoids the interop bottleneck. For this, we naively copy over the repository after checkout into WSL; and operate from in there.
Pending TODO is how we can properly cache contents inside WSL; as the cache action currently does not seem to pick it up properly.